plan-design-review
“Designer's eye plan review — interactive, like CEO and Eng review. (gstack)”
aipkg.jsonLICENSE.txtREADME.mdSKILL.mdSKILL.md.tmpl- 01SQP-285%MEDIUM
SKILL.md.tmpl:178
detailhide
The skill writes review metadata to `~/.gstack/` (user home directory) without explicit user consent in the description or warnings. This persists data outside the project and modifies user configuration without clear disclosure. Users may not expect skill execution to create/modify files in their home directory, violating principle of least surprise.
176177**PLAN MODE EXCEPTION — ALWAYS RUN:** These commands write design artifacts to178`~/.gstack/projects/$SLUG/designs/` (user config directory, not project files).179Mockups are design artifacts that inform the plan, not code changes. The gstack180designer outputs PNGs and HTML comparison boards for human review during thefix Add explicit warning in skill description: 'This skill writes review metadata to ~/.gstack/ directory for dashboard persistence.' Add AskUserQuestion before executing gstack-review-log command asking user to approve persistent storage of review data. Alternatively, default to project-local storage and only write to ~/.gstack/ with explicit opt-in.
- 02SQP-275%MEDIUM
SKILL.md.tmpl:114
detailhide
The skill executes arbitrary bash commands (git log, git diff, mkdir, cd, eval) with inline substitution without explicit confirmation prompts. While these are relatively benign read/mkdir operations, the pattern of executing bash without user confirmation creates risk surface. The 'eval' on line 114 is particularly concerning as it evaluates output from an external binary (gstack-slug).
112Before reviewing the plan, gather context:113114```bash115git log --oneline -15116git diff <base> --statfix Add explicit user confirmation via AskUserQuestion before executing any bash commands that modify state (mkdir, eval). For read-only commands (git log, git diff), at minimum log them clearly. Never use 'eval' on untrusted command output - parse it safely instead or require explicit user approval.